Allow token
to come from Kubernetes Secret rather than plaintext in Helm values
#15
+13
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to resolve #14.
Goals:
config.token
is specified, maintain existing chart behavior.config.token_secret_ref
is specified, omittoken
fromConfigMap
and modifyDeployment
to include an environment variable pulled from the Kubernetes Secret.values.schema.json
to require one ofconfig.token
orconfig.token_secret_ref
but that they are mutually exclusive.Testing procedure:
(PASSED)
ConfigMap
should not containtoken_secret_ref
but should containtoken
.Deployment
should not containtoken
environment variable.(PASSED)
ConfigMap
should not containtoken_secret_ref
and should not containtoken
.Deployment
should containtoken
environment variable populated by Secret.STILL TO DO:
values.schema.json
. I've never used JSON Schema.